Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759881AbcJ1N2f (ORCPT ); Fri, 28 Oct 2016 09:28:35 -0400 Received: from foss.arm.com ([217.140.101.70]:59492 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbcJ1N2e (ORCPT ); Fri, 28 Oct 2016 09:28:34 -0400 Date: Fri, 28 Oct 2016 14:28:29 +0100 From: Patrick Bellasi To: Rajesh P8 Cc: Peter Zijlstra , mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: common android definition bug in 3.18 kernel Message-ID: <20161028132828.GB31026@e105326-lin> References: <20161028072750.GP3102@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161028072750.GP3102@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1362 Lines: 35 On 28-Oct 09:27, Peter Zijlstra wrote: > On Fri, Oct 28, 2016 at 11:00:21AM +0530, Rajesh P8 wrote: > > Hi all, > > ? I am currently working on porting eas features using 3.18 common > > android kernel. In file ?kernel/sched/fair.c there is no definition > > for the function "trace_sched_boost_task(task, util, margin);" which > > is present in line 5142. Is it a bug or am I missing something? can I > > file this as a bug? > > > > This symbol has never existed in the mainline scheduler. You'll have to > go bug android people. Hi Rajesh, if you are working with the Android common kernel you should be aware that in that tree there are many different (sometimes experimental) features which are not present in Linux mainline kernel. Thus, this channel (i.e. LKML), as well as the people you are writing to, are not the one to bother about these issues. Probably, you should better start with a git blame to identify the "owner" of the code lines and eventually post a message directly to him. All that considered, what you are reporting is a tracepoint. Thus, you will not find a definition for this function in kernel/sched/fair.c. The tracepoint is defined in: include/trace/events/sched.h Here it is: https://android.googlesource.com/kernel/common/+/android-3.18/include/trace/events/sched.h#822 -- #include Patrick Bellasi