Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965652AbcJ1QJq (ORCPT ); Fri, 28 Oct 2016 12:09:46 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:35589 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752947AbcJ1QJn (ORCPT ); Fri, 28 Oct 2016 12:09:43 -0400 MIME-Version: 1.0 In-Reply-To: <1477667548-740-1-git-send-email-boris.brezillon@free-electrons.com> References: <1477667548-740-1-git-send-email-boris.brezillon@free-electrons.com> From: Geert Uytterhoeven Date: Fri, 28 Oct 2016 18:09:41 +0200 X-Google-Sender-Auth: QUuHcSklcjQUxIOGz5gLDHIW5c0 Message-ID: Subject: Re: [PATCH] m68k: Fix ndelay() macro To: Boris Brezillon Cc: linux-m68k , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 44 Hi Boris, On Fri, Oct 28, 2016 at 5:12 PM, Boris Brezillon wrote: > The current ndelay() macro definition has an extra semi-colon at the > end of the line thus leading to a compilation error when ndelay is used > in a conditional block with curly braces like this one: > > if (cond) > ndelay(t); > else > ... > > which, after the preprocessor pass gives: > > if (cond) > m68k_ndelay(t);; > else > ... > > thus leading to the following gcc error: > > error: 'else' without a previous 'if' > > Remove this extra semi-colon. > > Signed-off-by: Boris Brezillon Thank you, will apply and queue for v4.9. > Fixes: c8ee038bd1488 ("m68k: Implement ndelay() based on the existing udelay() logic") Wow, that's even a quite recent commit. Needs backporting only to v3.10+... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds