Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966066AbcJ1RkB (ORCPT ); Fri, 28 Oct 2016 13:40:01 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33257 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754415AbcJ1Rj7 (ORCPT ); Fri, 28 Oct 2016 13:39:59 -0400 Date: Fri, 28 Oct 2016 19:39:55 +0200 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: Joonwoo Park , linux-kernel@vger.kernel.org, Namhyung Kim , David Ahern , Jiri Olsa , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: Re: [GIT PULL] Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec() Message-ID: <20161028173955.GA24588@gmail.com> References: <1477600855-27580-1-git-send-email-acme@kernel.org> <1477600855-27580-9-git-send-email-acme@kernel.org> <41a9c8e5-044e-d42d-0e42-058b974d4f00@codeaurora.org> <20161028125338.GA28694@kernel.org> <20161028133041.GC28694@kernel.org> <20161028144245.GD28694@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161028144245.GD28694@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 31 * Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 28, 2016 at 11:30:41AM -0200, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Oct 28, 2016 at 10:53:38AM -0200, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park escreveu: > > > > Hmm.. I didn't ACK this patch because of bug I commented at > > > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html > > > > > s/work_list->max_lat/work_list->max_lat_at/ > > > > Sorry about that, I took the "thanks for taking care of this" as an ack, > > > now that I re-read that message I saw your points later on in that > > > e-mail. > > > > Since Ingo hasn't pulled this, I'll try fixing it, will check that other > > > naming issue, > > > So, here is how it ended up, it fixes the problem you pointed out and > > renames the function to follow the scnprintf() convention, as used > > elsewhere in tools/perf (tools/perf/util/annotate.h has several > > examples). > > Ingo, I've just signed a perf-core-for-mingo-20161028 with the only > change being the patch below, re-run my tests, I think this doesn't > introduce any bugs and addresses Joonwoo's concerns, please consider > pulling. Pulled, thanks a lot Arnaldo! Ingo