Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966230AbcJ1Rp5 (ORCPT ); Fri, 28 Oct 2016 13:45:57 -0400 Received: from terminus.zytor.com ([198.137.202.10]:32932 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936701AbcJ1Rpy (ORCPT ); Fri, 28 Oct 2016 13:45:54 -0400 Date: Fri, 28 Oct 2016 10:45:42 -0700 From: tip-bot for Namhyung Kim Message-ID: Cc: hpa@zytor.com, tglx@linutronix.de, a.p.zijlstra@chello.nl, dsahern@gmail.com, mingo@kernel.org, namhyung@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com Reply-To: tglx@linutronix.de, hpa@zytor.com, a.p.zijlstra@chello.nl, mingo@kernel.org, dsahern@gmail.com, namhyung@kernel.org, acme@redhat.com, jolsa@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20161024020246.14928-1-namhyung@kernel.org> References: <20161024020246.14928-1-namhyung@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf sched map: Apply cpu color when there's an activity Git-Commit-ID: 1208bb274ba547012579d5b68c693e0b36682b74 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1374 Lines: 36 Commit-ID: 1208bb274ba547012579d5b68c693e0b36682b74 Gitweb: http://git.kernel.org/tip/1208bb274ba547012579d5b68c693e0b36682b74 Author: Namhyung Kim AuthorDate: Mon, 24 Oct 2016 11:02:43 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 25 Oct 2016 15:04:48 -0300 perf sched map: Apply cpu color when there's an activity Applying cpu color always doesn't help readability IMHO. Instead it might be better to applying the color when there's an activity on those CPUs. Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa Cc: David Ahern Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20161024020246.14928-1-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index 8ca1b540..a8ad859 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -1479,7 +1479,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel, cpu_color = COLOR_CPUS; if (cpu != this_cpu) - color_fprintf(stdout, cpu_color, " "); + color_fprintf(stdout, color, " "); else color_fprintf(stdout, cpu_color, "*");