Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034277AbcJ1Rqr (ORCPT ); Fri, 28 Oct 2016 13:46:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44684 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966135AbcJ1Rqo (ORCPT ); Fri, 28 Oct 2016 13:46:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org EE82D615E3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=joonwoop@codeaurora.org Subject: Re: [GIT PULL] Re: [PATCH 08/15] perf tools: Introduce timestamp_in_usec() To: Ingo Molnar , Arnaldo Carvalho de Melo References: <1477600855-27580-1-git-send-email-acme@kernel.org> <1477600855-27580-9-git-send-email-acme@kernel.org> <41a9c8e5-044e-d42d-0e42-058b974d4f00@codeaurora.org> <20161028125338.GA28694@kernel.org> <20161028133041.GC28694@kernel.org> <20161028144245.GD28694@kernel.org> <20161028173955.GA24588@gmail.com> Cc: linux-kernel@vger.kernel.org, Namhyung Kim , David Ahern , Jiri Olsa , Peter Zijlstra , Arnaldo Carvalho de Melo From: Joonwoo Park Message-ID: Date: Fri, 28 Oct 2016 10:46:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161028173955.GA24588@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 44 On 10/28/2016 10:39 AM, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > >> Em Fri, Oct 28, 2016 at 11:30:41AM -0200, Arnaldo Carvalho de Melo escreveu: >>> Em Fri, Oct 28, 2016 at 10:53:38AM -0200, Arnaldo Carvalho de Melo escreveu: >>>> Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park escreveu: >>>>> Hmm.. I didn't ACK this patch because of bug I commented at >>>>> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html >> >>>>> s/work_list->max_lat/work_list->max_lat_at/ >> >>>> Sorry about that, I took the "thanks for taking care of this" as an ack, >>>> now that I re-read that message I saw your points later on in that >>>> e-mail. No worries. I think I could be more specific with the first part of comment by mentioning about the bug. >> >>>> Since Ingo hasn't pulled this, I'll try fixing it, will check that other >>>> naming issue, >> >>> So, here is how it ended up, it fixes the problem you pointed out and >>> renames the function to follow the scnprintf() convention, as used >>> elsewhere in tools/perf (tools/perf/util/annotate.h has several >>> examples). >> >> Ingo, I've just signed a perf-core-for-mingo-20161028 with the only >> change being the patch below, re-run my tests, I think this doesn't >> introduce any bugs and addresses Joonwoo's concerns, please consider >> pulling. > > Pulled, thanks a lot Arnaldo! Thanks! Joonwoo > > Ingo >