Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942678AbcJ1V1A (ORCPT ); Fri, 28 Oct 2016 17:27:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51870 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941762AbcJ1V06 (ORCPT ); Fri, 28 Oct 2016 17:26:58 -0400 Date: Fri, 28 Oct 2016 14:26:57 -0700 From: Andrew Morton To: Chris Wilson Cc: Guenter Roeck , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, Stephen Rothwell Subject: Re: Crash in -next due to 'mm/vmalloc: replace opencoded 4-level page walkers' Message-Id: <20161028142657.3f4b23114737462043a4e109@linux-foundation.org> In-Reply-To: <20161028201548.GA16450@nuc-i3427.alporthouse.com> References: <20161028171825.GA15116@roeck-us.net> <20161028201548.GA16450@nuc-i3427.alporthouse.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 514 Lines: 10 On Fri, 28 Oct 2016 21:15:48 +0100 Chris Wilson wrote: > > Bisect points to commit 0c79e3331f08 ("mm/vmalloc: replace opencoded 4-level > > page walkers"). Reverting this patch fixes the problem. > > Hmm, apply_to_pte_range() has a BUG_ON(pmd_huge(*pmd)) but the old > vmap_pte_range() does not and neither has the code to handle that case. > Presuming that the BUG_ON() there is actually meaningful. Thanks, I'll drop mm-vmalloc-replace-opencoded-4-level-page-walkers.patch for now.