Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030563AbcJ1XbF (ORCPT ); Fri, 28 Oct 2016 19:31:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33688 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755243AbcJ1XbB (ORCPT ); Fri, 28 Oct 2016 19:31:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org CA94B61185 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 28 Oct 2016 16:30:59 -0700 From: Stephen Boyd To: Laura Abbott Cc: Michael Turquette , Loc Ho , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] clk: xgene: Don't call __pa on ioremaped address Message-ID: <20161028233059.GO16026@codeaurora.org> References: <1477673978-15424-1-git-send-email-labbott@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477673978-15424-1-git-send-email-labbott@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 611 Lines: 17 On 10/28, Laura Abbott wrote: > ioremaped addresses are not linearly mapped so the physical > address can not be figured out via __pa. More generally, there > is no guarantee that backing value of an ioremapped address > is a physical address at all. The value here is only used > for debugging so just drop the call to __pa on the ioremapped > address. > > Fixes: 6ae5fd381251 ("clk: xgene: Silence sparse warnings") > Signed-off-by: Laura Abbott > --- Applied to clk-fixes -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project