Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938864AbcJ2Cou (ORCPT ); Fri, 28 Oct 2016 22:44:50 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35324 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbcJ2Cot (ORCPT ); Fri, 28 Oct 2016 22:44:49 -0400 From: Brian Norris To: Andy Whitcroft , Joe Perches Cc: , Brian Norris , Linus Torvalds , Andrew Morton , SF Markus Elfring Subject: [PATCH v2] checkpatch: fix uninitialized var when run with --no-tree Date: Fri, 28 Oct 2016 19:44:32 -0700 Message-Id: <1477709072-94668-1-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 32 If checkpatch.pl gets copied out of the tree, --no-tree shouldn't start complaining: Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764. Let's just give the safe answer instead -- don't warn about "obsolete" files. Fixes: 85b0ee18bbf8 ("checkpatch: see if modified files are marked obsolete in MAINTAINERS") Signed-off-by: Brian Norris --- v2: change condition to check for $root, not $tree scripts/checkpatch.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a8368d1c4348..c9cbfed326a7 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -761,6 +761,8 @@ sub seed_camelcase_file { sub is_maintained_obsolete { my ($filename) = @_; + return 0 if (!defined $root); + return 0 if (!(-e "$root/scripts/get_maintainer.pl")); my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`; -- 2.8.0.rc3.226.g39d4020