Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757068AbcJ2G3v (ORCPT ); Sat, 29 Oct 2016 02:29:51 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35468 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806AbcJ2G13 (ORCPT ); Sat, 29 Oct 2016 02:27:29 -0400 From: frowand.list@gmail.com To: Rob Herring , pantelis.antoniou@konsulko.com, Pantelis Antoniou Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/12] of: Remove redundant size check Date: Fri, 28 Oct 2016 23:26:28 -0700 Message-Id: <1477722392-32172-9-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1477722392-32172-1-git-send-email-frowand.list@gmail.com> References: <1477722392-32172-1-git-send-email-frowand.list@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 24 From: Frank Rowand Remove a redundant check of buffer size. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 708daca1d522..76c09cb57eae 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c @@ -216,7 +216,7 @@ static int adjust_local_phandle_references(struct device_node *local_fixups, for (i = 0; i < count; i++) { off = be32_to_cpu(((__be32 *)prop_fix->value)[i]); - if (off >= prop->length || (off + 4) > prop->length) + if ((off + 4) > prop->length) return -EINVAL; phandle = be32_to_cpu(*(__be32 *)(prop->value + off)); -- 1.9.1