Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034257AbcJ2ISy (ORCPT ); Sat, 29 Oct 2016 04:18:54 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:57271 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943147AbcJ2ISs (ORCPT ); Sat, 29 Oct 2016 04:18:48 -0400 Date: Sat, 29 Oct 2016 10:18:39 +0200 From: Andrew Lunn To: Jon Mason Cc: David Miller , Rob Herring , Mark Rutland , Florian Fainelli , devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, rafal@milecki.pl, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/6] net: phy: broadcom: Add BCM54810 PHY entry Message-ID: <20161029081839.GA32579@lunn.ch> References: <1477688219-3871-1-git-send-email-jon.mason@broadcom.com> <1477688219-3871-3-git-send-email-jon.mason@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477688219-3871-3-git-send-email-jon.mason@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 31 On Fri, Oct 28, 2016 at 04:56:55PM -0400, Jon Mason wrote: > The BCM54810 PHY requires some semi-unique configuration, which results > in some additional configuration in addition to the standard config. > Also, some users of the BCM54810 require the PHY lanes to be swapped. > Since there is no way to detect this, add a device tree query to see if > it is applicable. > > Inspired-by: Vikas Soni > Signed-off-by: Jon Mason > --- > drivers/net/phy/Kconfig | 2 +- > drivers/net/phy/broadcom.c | 58 +++++++++++++++++++++++++++++++++++++++++++++- > include/linux/brcmphy.h | 10 ++++++++ Hi Jon The binding documentation is missing. > + if (of_property_read_bool(np, "brcm,enet-phy-lane-swap")) { > + /* Lane Swap - Undocumented register...magic! */ > + ret = bcm_phy_write_exp(phydev, MII_BCM54XX_EXP_SEL_ER + 0x9, > + 0x11B); > + if (ret < 0) > + return ret; > + } > + I wounder if this property could be made generic? What exactly are you swapping? Rx and Tx lanes? Maybe we should add it to phy.txt? Andrew