Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943052AbcJ2I1H (ORCPT ); Sat, 29 Oct 2016 04:27:07 -0400 Received: from mail-qk0-f176.google.com ([209.85.220.176]:36854 "EHLO mail-qk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934648AbcJ2I1B (ORCPT ); Sat, 29 Oct 2016 04:27:01 -0400 MIME-Version: 1.0 In-Reply-To: <20161026233228.15219-1-michael.scott@linaro.org> References: <20161026233228.15219-1-michael.scott@linaro.org> From: Linus Walleij Date: Sat, 29 Oct 2016 10:27:00 +0200 Message-ID: Subject: Re: [PATCH V2] pinctrl: qcom: Add msm8994 pinctrl driver To: Michael Scott , Bjorn Andersson Cc: "linux-gpio@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rob Herring , Mark Rutland , Andy Gross , David Brown , Joonwoo Park , Jeremy McNicoll Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9T8REBd019561 Content-Length: 1298 Lines: 32 On Thu, Oct 27, 2016 at 1:32 AM, Michael Scott wrote: > Initial pinctrl driver for QCOM msm8994 platforms. > > In order to continue the initial board support for QCOM msm8994/msm8992 > presented in patches from Jeremy McNicoll , let's put > a proper pinctrl driver in place. > > Currently, the DT for these platforms uses the msm8x74 pinctrl driver to enable > basic UART. Beyond the first few pins the rest are different enough to justify > it's own driver. > > Note: This driver is also be used by QCOM's msm8992 platform as it's TLM block > is the same. > > - Initial formatting and style was taken from the msm8x74 pinctrl driver added > by Björn Andersson > - Data was then adjusted per QCOM MSM8994 documentation for Top Level Multiplexing > - Bindings documentation was based on qcom,msm8996-pinctrl.txt by > Joonwoo Park and then modified for msm8994 content > > Signed-off-by: Michael Scott > --- > > V1 -> V2: fixed missing FUNCTION(nav_pps) and removed 3 odd newlines between blsp_i2c4_groups and cci_timer0_groups Looks fine to me, just like the other Qcom drivers. I just want Björn Andersson's ACK before merging, Björn? Yours, Linus Walleij