Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934340AbcJ2SHF (ORCPT ); Sat, 29 Oct 2016 14:07:05 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35847 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbcJ2SHD (ORCPT ); Sat, 29 Oct 2016 14:07:03 -0400 Date: Sat, 29 Oct 2016 11:06:58 -0700 From: Bjorn Andersson To: Michael Scott Cc: linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Rob Herring , Mark Rutland , Andy Gross , David Brown , Joonwoo Park , Jeremy McNicoll Subject: Re: [PATCH V2] pinctrl: qcom: Add msm8994 pinctrl driver Message-ID: <20161029180658.GD25787@tuxbot> References: <20161026233228.15219-1-michael.scott@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161026233228.15219-1-michael.scott@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 37 On Wed 26 Oct 16:32 PDT 2016, Michael Scott wrote: > Initial pinctrl driver for QCOM msm8994 platforms. > > In order to continue the initial board support for QCOM msm8994/msm8992 > presented in patches from Jeremy McNicoll , let's put > a proper pinctrl driver in place. > > Currently, the DT for these platforms uses the msm8x74 pinctrl driver to enable > basic UART. Beyond the first few pins the rest are different enough to justify > it's own driver. > > Note: This driver is also be used by QCOM's msm8992 platform as it's TLM block > is the same. > I'm not up to speed on the 8992/8994 story, but please add a "qcom,msm8992-pinctrl" compatible to the list as well. > - Initial formatting and style was taken from the msm8x74 pinctrl driver added > by Bj?rn Andersson > - Data was then adjusted per QCOM MSM8994 documentation for Top Level Multiplexing I think this is good enough. It looks reasonable and you based it on the data sheet. Any fixes to the tables can be added incrementally. > - Bindings documentation was based on qcom,msm8996-pinctrl.txt by > Joonwoo Park and then modified for msm8994 content > > Signed-off-by: Michael Scott Please add the compatible and you have my Acked-by: Bjorn Andersson Regards, Bjorn