Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753615AbcJ2Skt (ORCPT ); Sat, 29 Oct 2016 14:40:49 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35970 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbcJ2Sks (ORCPT ); Sat, 29 Oct 2016 14:40:48 -0400 Date: Sat, 29 Oct 2016 12:40:31 -0600 From: Mark Brown To: Axel Haslam Cc: Liam Girdwood , Kevin Hilman , Sekhar Nori , David Lechner , linux-kernel@vger.kernel.org Message-ID: <20161029184031.adjybckguxzfu3pq@sirena.org.uk> References: <20161026190054.11968-1-ahaslam@baylibre.com> <20161026190054.11968-2-ahaslam@baylibre.com> <20161028182250.df6p6setaauxsezu@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kxxx36qsgw36r77u" Content-Disposition: inline In-Reply-To: X-Cookie: Serenity through viciousness. User-Agent: NeoMutt/20161014 (1.7.1) X-SA-Exim-Connect-IP: 63.233.104.126 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC 1/3] regulator: core: Add over current changed event X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 34 --kxxx36qsgw36r77u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2016 at 09:41:44PM +0200, Axel Haslam wrote: > i think today each time an event occurs a notification is sent with the > corresponding flag(s) set. Right, so I think the problem here is actually that you called this=20 REGULATOR_EVENT_OVER_CURRENT_CHANGE with the _CHANGE on the end which means it's just saying that the user has to go poll to see if the device is or is not over current separately at which point you may as well pull in all the other error things into what you're polling for. If you'd dropped the _CHANGE it'd be consistent with the other events we have for errors and fine. --kxxx36qsgw36r77u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAABCAAGBQJYFO0eAAoJECTWi3JdVIfQYfQH/RqyGJgEtQ8HP2XZ7oBrqlyP OSGuqsUMMgKfSMsjpl44X9C4lOleFPfM5voWq/f7dx3Xt9VUyXfq62IASOud0RpR 0tPLzIJyQjgw9HdcaAcjph8XBp/JJ+CMGTxRBqJ7xg4EByu9NZ0upcXC6JKmMSr9 2A/31Se5Hz+1Iey4jJKABRXGAdtaP1wu+zywH3mzJKFs25tZyOjhZ6bIhMDc4A4F COK+OneOZnlq4Xk9bsPpGr551AUb4UHNdVU+iuSQ2NztLc4ItFjNCMcDmiD5AJ+N vFfZkRyjIVdLxDXEianSHUyWKLIxzmUq10xFxPW67fE+as4uT6ij82LY7236ec0= =IRZT -----END PGP SIGNATURE----- --kxxx36qsgw36r77u--