Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756089AbcJ3D5o (ORCPT ); Sat, 29 Oct 2016 23:57:44 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33874 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbcJ3D5n (ORCPT ); Sat, 29 Oct 2016 23:57:43 -0400 Subject: Re: [PATCH -next] brd: make symbol rd_size static To: Wei Yongjun , Jan Kara References: <1477757427-26162-1-git-send-email-weiyj.lk@gmail.com> Cc: Wei Yongjun , linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: Date: Sat, 29 Oct 2016 21:57:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477757427-26162-1-git-send-email-weiyj.lk@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 449 Lines: 19 On 10/29/2016 10:10 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/block/brd.c:411:15: warning: > symbol 'rd_size' was not declared. Should it be static? We just tried this, it's used in arm: arch/arm/kernel/atags_parse.c static int __init parse_tag_ramdisk(const struct tag *tag) { extern int rd_size, rd_image_start, rd_prompt, rd_doload; [...] -- Jens Axboe