Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347AbcJ3Mds (ORCPT ); Sun, 30 Oct 2016 08:33:48 -0400 Received: from mail.osadl.at ([92.243.35.153]:37162 "EHLO mail.osadl.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905AbcJ3Mdr (ORCPT ); Sun, 30 Oct 2016 08:33:47 -0400 Date: Sun, 30 Oct 2016 12:33:25 +0000 From: Nicholas Mc Guire To: Faisal Latif Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: RFC if==else in i40iw_virtchnl. Message-ID: <20161030123325.GA26456@osadl.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 19 Hi Faisal ! your commit 4097351a47c5 ("i40iw: virtual channel handling files") adds the following lines in i40iw_vchnl_recv_pf() + if (vchnl_msg->iw_op_ver != I40IW_VCHNL_OP_GET_VER_V0) + vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg); + else + vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg); + return I40IW_SUCCESS; as the if==else here this looks buggy - if it is intended it atleast needs a comment/explaination but it did not seem to make much sense in this form (Note this is the only place where vchnl_pf_send_get_ver_resp() is being called so the intent is not clear from code review and thus no patch can be resonably suggested. thx! hofrat