Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754889AbcJ3Mkf (ORCPT <rfc822;w@1wt.eu>);
        Sun, 30 Oct 2016 08:40:35 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:36436 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751521AbcJ3Mke (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 30 Oct 2016 08:40:34 -0400
Subject: Re: [PATCH -next] brd: make symbol rd_size static
To: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>
References: <1477757427-26162-1-git-send-email-weiyj.lk@gmail.com>
 <e8c13474-d035-7e03-1eee-a0ccf7a5c799@kernel.dk>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-kernel@vger.kernel.org
From: Wei Yongjun <weiyj.lk@gmail.com>
Message-ID: <0a1d6cbb-6797-e295-0d9c-7e814c1ebb21@gmail.com>
Date: Sun, 30 Oct 2016 20:40:12 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <e8c13474-d035-7e03-1eee-a0ccf7a5c799@kernel.dk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 561
Lines: 24

On 10/30/2016 11:57 AM, Jens Axboe wrote:
> On 10/29/2016 10:10 AM, Wei Yongjun wrote:
>> From: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> Fixes the following sparse warning:
>>
>> drivers/block/brd.c:411:15: warning:
>>  symbol 'rd_size' was not declared. Should it be static?
>
> We just tried this, it's used in arm:
>
> arch/arm/kernel/atags_parse.c
>
> static int __init parse_tag_ramdisk(const struct tag *tag)
> {
>         extern int rd_size, rd_image_start, rd_prompt, rd_doload;
> [...]
>
Oh, yeah, got it.

Thank you very much.

Regards,
Yongjun Wei