Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756260AbcJ3NnW (ORCPT ); Sun, 30 Oct 2016 09:43:22 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44098 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751670AbcJ3NnU (ORCPT ); Sun, 30 Oct 2016 09:43:20 -0400 Date: Sun, 30 Oct 2016 14:43:08 +0100 From: Martin Schwidefsky To: Paul Gortmaker Cc: , Greg Kroah-Hartman , Heiko Carstens , Michael Holzheu , Subject: Re: [PATCH 3/3] s390: char: make slp_ctl explicitly non-modular In-Reply-To: <20161029203843.515-4-paul.gortmaker@windriver.com> References: <20161029203843.515-1-paul.gortmaker@windriver.com> <20161029203843.515-4-paul.gortmaker@windriver.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16103013-0036-0000-0000-0000024F2E08 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16103013-0037-0000-0000-0000130E4CDF Message-Id: <20161030144308.03a804de@mschwide> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-30_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610300246 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 29 On Sat, 29 Oct 2016 16:38:43 -0400 Paul Gortmaker wrote: > The Makefile currently controlling compilation of this code is obj-y, > meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular usage, so that when reading > the driver there is no doubt it is builtin-only. > > Since module_misc_device translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Paul Gortmaker > Cc: Michael Holzheu > Cc: linux-s390@vger.kernel.org > Signed-off-by: Paul Gortmaker That idea behind the patch makes sense to me. But the built robot reports a new warning which should be fixed. If that is done: Acked-by: Martin Schwidefsky -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.