Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932413AbcJ3QF6 (ORCPT ); Sun, 30 Oct 2016 12:05:58 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:40254 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754090AbcJ3QF4 (ORCPT ); Sun, 30 Oct 2016 12:05:56 -0400 From: Guenter Roeck To: Ralf Baechle Cc: Alex Smith , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Guenter Roeck , James Hogan Subject: [PATCH] MIPS: VDSO: Always select -msoft-float Date: Sun, 30 Oct 2016 09:05:51 -0700 Message-Id: <1477843551-21813-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.5.0 X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 35 Some toolchains fail to build mips images with the following build error. arch/mips/vdso/gettimeofday.c:1:0: error: '-march=r3000' requires '-mfp32' This is seen, for example, with the 'mipsel-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705' toolchain as used by the 0Day build robot when building decstation_defconfig. Comparison of compile flags suggests that the major difference is a missing '-soft-float', which is otherwise defined unconditionally. Reported-by: kbuild test robot Cc: James Hogan Fixes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO") Signed-off-by: Guenter Roeck --- arch/mips/vdso/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile index c3dc12a8b7d9..9bdd6641400f 100644 --- a/arch/mips/vdso/Makefile +++ b/arch/mips/vdso/Makefile @@ -6,7 +6,8 @@ ccflags-vdso := \ $(filter -I%,$(KBUILD_CFLAGS)) \ $(filter -E%,$(KBUILD_CFLAGS)) \ $(filter -mmicromips,$(KBUILD_CFLAGS)) \ - $(filter -march=%,$(KBUILD_CFLAGS)) + $(filter -march=%,$(KBUILD_CFLAGS)) \ + -msoft-float cflags-vdso := $(ccflags-vdso) \ $(filter -W%,$(filter-out -Wa$(comma)%,$(KBUILD_CFLAGS))) \ -O2 -g -fPIC -fno-strict-aliasing -fno-common -fno-builtin -G 0 \ -- 2.5.0