Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753797AbcJ3VMt (ORCPT ); Sun, 30 Oct 2016 17:12:49 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36261 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752458AbcJ3VMr (ORCPT ); Sun, 30 Oct 2016 17:12:47 -0400 Subject: Re: [PATCH v4 05/10] IB/isert: Replace semaphore sem with completion To: Binoy Jayan , Doug Ledford , Sean Hefty , Hal Rosenstock References: <1477551554-30349-1-git-send-email-binoy.jayan@linaro.org> <1477551554-30349-6-git-send-email-binoy.jayan@linaro.org> Cc: Arnd Bergmann , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org From: Sagi Grimberg Message-ID: Date: Sun, 30 Oct 2016 23:12:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477551554-30349-6-git-send-email-binoy.jayan@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 502 Lines: 12 > The semaphore 'sem' in isert_device is used as completion, so convert > it to struct completion. Semaphores are going away in the future. Umm, this is 100% *not* true. np->sem is designed as a counting to sync the iscsi login thread with the connect requests coming from the initiators. So this is actually a reliable bug insertion :( NAK from me... Also, I would appreciate if you include get_maintainer.pl in your patch submissions so I won't need to fish these in the Linux-rdma patch traffic.