Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933370AbcJaBRz (ORCPT ); Sun, 30 Oct 2016 21:17:55 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:51391 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933142AbcJaBRw (ORCPT ); Sun, 30 Oct 2016 21:17:52 -0400 Date: Sun, 30 Oct 2016 19:15:06 -0600 (MDT) From: Thomas Gleixner To: Grzegorz Andrejczuk cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de, dave.hansen@linux.intel.com, lukasz.daniluk@intel.com, james.h.cownie@intel.com, jacob.jun.pan@intel.com, Piotr.Luc@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 3/4] x86/cpufeature: Add PHIR3MWAIT to CPU features In-Reply-To: <1477662595-21011-4-git-send-email-grzegorz.andrejczuk@intel.com> Message-ID: References: <1477662595-21011-1-git-send-email-grzegorz.andrejczuk@intel.com> <1477662595-21011-4-git-send-email-grzegorz.andrejczuk@intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 27 On Fri, 28 Oct 2016, Grzegorz Andrejczuk wrote: > Add Intel Xeon Phi x200 (KnightsLanding) cpu feature - ring 3 monitor/mwait > > Signed-off-by: Grzegorz Andrejczuk > --- > arch/x86/include/asm/cpufeatures.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index 92a8308..eb88eeb 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -101,6 +101,7 @@ > #define X86_FEATURE_TSC_RELIABLE ( 3*32+23) /* TSC is known to be reliable */ > #define X86_FEATURE_NONSTOP_TSC ( 3*32+24) /* TSC does not stop in C states */ > /* free, was #define X86_FEATURE_CLFLUSH_MONITOR ( 3*32+25) * "" clflush reqd with monitor */ Bah. Do you really think that this comment is still useful? Can you please get your act together and switch on your brain instead of mindlessly slapping stuff into the code? > +#define X86_FEATURE_PHIR3MWAIT ( 3*32+25) /* Xeon Phi x200 ring 3 MONITOR/MWAIT */ Thanks, tglx