Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757394AbcJaEiG (ORCPT ); Mon, 31 Oct 2016 00:38:06 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34015 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756013AbcJaEiD (ORCPT ); Mon, 31 Oct 2016 00:38:03 -0400 Date: Sun, 30 Oct 2016 23:37:59 -0500 From: Rob Herring To: Olimpiu Dejeu Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, jg1.han@samsung.com Subject: Re: [PATCH 2/2] backlight: arcxcnn: devicetree bindings for ArticSand devices Message-ID: <20161031043759.s5gmht6obqsqdn2d@rob-hp-laptop> References: <1477513801-31350-1-git-send-email-olimpiu@arcticsand.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477513801-31350-1-git-send-email-olimpiu@arcticsand.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2069 Lines: 60 On Wed, Oct 26, 2016 at 04:30:01PM -0400, Olimpiu Dejeu wrote: > Resubmition of arcxcnn backliught driver bindings with added register > documentation > > Signed-off-by: Olimpiu Dejeu > > --- > .../bindings/leds/backlight/arcxcnn_bl.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > > diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > new file mode 100644 > index 0000000..a7b6ff2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > @@ -0,0 +1,31 @@ > +Binding for ArcticSand arc2c0608 LED driver > + > +Required properties: > +- compatible: should be "arc,arc2c0608" What's the correct vendor prefix? arc or arcticsand used below? > +- reg: slave address > + > +Optional properties: > +- default-brightness: brightness value on boot, value from: 0-4095 > +- label: The name of the backlight device > + See Documentation/devicetree/bindings/leds/common.txt > +- led-sources: List of enabled channels from 0 to 5. > + See Documentation/devicetree/bindings/leds/common.txt > + > +- arcticsand,led-config-0: setting for register ILED_CONFIG_0 > +- arcticsand,led-config-1: setting for register ILED_CONFIG_1 > +- arcticsand,dim-freq: PWM mode frequence setting (bits [3:0] used) > +- arcticsand,comp-config: setting for register CONFIG_COMP > +- arcticsand,filter-config: setting for register FILTER_CONFIG > +- arcticsand,trim-config: setting for register IMAXTUNE What are the default values if not present? What determines these settings? If the board design, then okay. If a an enduser wants to adjust, then they shouldn't be in DT. > + > +Example: > + > +arc2c0608@30 { > + compatible = "arc,arc2c0608"; > + reg = <0x30>; > + default-brightness = <500>; > + label = "lcd-backlight"; > + linux,default-trigger = "backlight"; > + led-sources = <0 1 2 5>; > +}; > + > -- > 2.7.4 >