Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758916AbcJaFhw (ORCPT ); Mon, 31 Oct 2016 01:37:52 -0400 Received: from ozlabs.org ([103.22.144.67]:46965 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758858AbcJaFhv (ORCPT ); Mon, 31 Oct 2016 01:37:51 -0400 From: Michael Ellerman To: Christophe JAILLET , imunsie@au1.ibm.com, fbarrat@linux.vnet.ibm.com Cc: kernel-janitors@vger.kernel.org, Christophe JAILLET , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cxl: Fix error handling In-Reply-To: <20161030214047.25037-1-christophe.jaillet@wanadoo.fr> References: <20161030214047.25037-1-christophe.jaillet@wanadoo.fr> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 31 Oct 2016 16:37:49 +1100 Message-ID: <87wpgp13ki.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 21 Christophe JAILLET writes: > 'cxl_dev_context_init()' returns an error pointer in case of error, not > NULL. So test it with IS_ERR. > > Signed-off-by: Christophe JAILLET > --- > un-compiled because I don't have the required cross build environment. Do you run Ubuntu or Fedora? If so it's just a dnf/apt-get away: $ sudo dnf install gcc-c++-powerpc64-linux-gnu binutils-powerpc64-linux-gnu gcc-powerpc64-linux-gnu or $ sudo apt-get install gcc-powerpc64le-linux-gnu gcc-powerpc-linux-gnu libc-dev-powerpc-cross libc-dev-ppc64el-cross More here: https://github.com/linuxppc/linux/wiki/Building-powerpc-kernels cheers