Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759704AbcJaGHE (ORCPT ); Mon, 31 Oct 2016 02:07:04 -0400 Received: from ozlabs.org ([103.22.144.67]:46637 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759537AbcJaGHA (ORCPT ); Mon, 31 Oct 2016 02:07:00 -0400 From: Michael Ellerman To: Julia Lawall , Benjamin Herrenschmidt Cc: kernel-janitors@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/15] powerpc/iommu: use permission-specific DEVICE_ATTR variants In-Reply-To: <1477769829-22230-9-git-send-email-Julia.Lawall@lip6.fr> References: <1477769829-22230-1-git-send-email-Julia.Lawall@lip6.fr> <1477769829-22230-9-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 31 Oct 2016 17:06:58 +1100 Message-ID: <87twbt127x.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 524 Lines: 18 Julia Lawall writes: > diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c > index 5f202a5..32f18b5 100644 > --- a/arch/powerpc/kernel/iommu.c > +++ b/arch/powerpc/kernel/iommu.c > @@ -127,8 +127,7 @@ static ssize_t fail_iommu_store(struct device *dev, > return count; > } > > -static DEVICE_ATTR(fail_iommu, S_IRUGO|S_IWUSR, fail_iommu_show, > - fail_iommu_store); > +static DEVICE_ATTR_RW(fail_iommu); Acked-by: Michael Ellerman (powerpc) cheers