Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759943AbcJaGQd (ORCPT ); Mon, 31 Oct 2016 02:16:33 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:35921 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759651AbcJaGQb (ORCPT ); Mon, 31 Oct 2016 02:16:31 -0400 Date: Mon, 31 Oct 2016 01:16:28 -0500 From: Rob Herring To: Joshua Clayton Cc: Alan Tull , Moritz Fischer , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/5] doc: dt: add cyclone-spi binding document Message-ID: <20161031061628.focirubj6qmxwyn3@rob-hp-laptop> References: <2de74f6d2f2689b8ef090a9017db2ffb3bd319cb.1477669745.git.stillcompiling@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2de74f6d2f2689b8ef090a9017db2ffb3bd319cb.1477669745.git.stillcompiling@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1799 Lines: 47 On Fri, Oct 28, 2016 at 09:56:39AM -0700, Joshua Clayton wrote: > Describe a cyclonei-ps-spi devicetree entry, required features > > Signed-off-by: Joshua Clayton > --- > .../bindings/fpga/cyclone-ps-spi-fpga-mgr.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/fpga/cyclone-ps-spi-fpga-mgr.txt > > diff --git a/Documentation/devicetree/bindings/fpga/cyclone-ps-spi-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/cyclone-ps-spi-fpga-mgr.txt > new file mode 100644 > index 0000000..c942281 > --- /dev/null > +++ b/Documentation/devicetree/bindings/fpga/cyclone-ps-spi-fpga-mgr.txt > @@ -0,0 +1,23 @@ > +Altera Cyclone Passive Serial SPI FPGA Manager > + > +Altera Cyclone FPGAs support a method of loading the bitstream over what is > +referred to as "passive serial". > +The passive serial link is not technically spi, and might require extra > +circuits in order to play nicely with other spi slaves on the same bus. > + > +See https://www.altera.com/literature/hb/cyc/cyc_c51013.pdf > + > +Required properties: > +- compatible : should contain "altr,cyclone-ps-spi-fpga-mgr" > +- reg : spi slave id of the fpga > +- config-gpio : config pin (referred to as nCONFIG in the cyclone manual) > +- status-gpio : status pin (referred to as nSTATUS in the cyclone manual) '-gpios' is the preferred form. Looks like active low to me with nXXXX, but the example says active high. Please be specific here. > + > +Example: > + fpga_spi: evi-fpga-spi@0 { > + compatible = "altr,cyclone-ps-spi-fpga-mgr"; > + spi-max-frequency = <20000000>; > + reg = <0>; > + config-gpio = <&gpio4 9 GPIO_ACTIVE_HIGH>; > + status-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>; > + }; > -- > 2.7.4 >