Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934805AbcJaGUk (ORCPT ); Mon, 31 Oct 2016 02:20:40 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35822 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759721AbcJaGUi (ORCPT ); Mon, 31 Oct 2016 02:20:38 -0400 Date: Mon, 31 Oct 2016 01:20:35 -0500 From: Rob Herring To: Jon Mason Cc: David Miller , Mark Rutland , Florian Fainelli , rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] Documentation: devicetree: net: add NS2 bindings to amac Message-ID: <20161031062035.5hzolwhjnwcs72kg@rob-hp-laptop> References: <1477688219-3871-1-git-send-email-jon.mason@broadcom.com> <1477688219-3871-4-git-send-email-jon.mason@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477688219-3871-4-git-send-email-jon.mason@broadcom.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1403 Lines: 37 On Fri, Oct 28, 2016 at 04:56:56PM -0400, Jon Mason wrote: > Signed-off-by: Jon Mason > --- > Documentation/devicetree/bindings/net/brcm,amac.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/brcm,amac.txt b/Documentation/devicetree/bindings/net/brcm,amac.txt > index ba5ecc1..f2b194e 100644 > --- a/Documentation/devicetree/bindings/net/brcm,amac.txt > +++ b/Documentation/devicetree/bindings/net/brcm,amac.txt > @@ -2,11 +2,12 @@ Broadcom AMAC Ethernet Controller Device Tree Bindings > ------------------------------------------------------------- > > Required properties: > - - compatible: "brcm,amac" or "brcm,nsp-amac" > + - compatible: "brcm,amac", "brcm,nsp-amac", or "brcm,ns2-amac" One per line is preferred. > - reg: Address and length of the GMAC registers, > Address and length of the GMAC IDM registers > + Address and length of the NIC Port Manager registers (optional) > - reg-names: Names of the registers. Must have both "amac_base" and > - "idm_base" > + "idm_base". "nicpm_base" is optional (required for NS2) Is nicpm_base optional on some SoCs? If not just say which ones it applies to. A separate line will make that clearer. _base is kind of redundant too, but it's already done. > - interrupts: Interrupt number > > Optional properties: > -- > 2.7.4 >