Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762034AbcJaIFo (ORCPT ); Mon, 31 Oct 2016 04:05:44 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35608 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761936AbcJaIFk (ORCPT ); Mon, 31 Oct 2016 04:05:40 -0400 Date: Mon, 31 Oct 2016 16:05:35 +0800 From: Eva Rachel Retuya To: Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org Subject: Re: [PATCH v3] staging: iio: cdc: ad7746: add additional config defines Message-ID: <20161031080534.GB2207@Socrates-DK> Mail-Followup-To: Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org References: <1477643212-7200-1-git-send-email-eraretuya@gmail.com> <48d88156-88a9-dcc9-48d8-809d992c56e1@metafoo.de> <5ef0f1e1-236c-0698-cdfc-533125b2d2c7@kernel.org> <20161031074901.GA2207@Socrates-DK> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161031074901.GA2207@Socrates-DK> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 43 On Mon, Oct 31, 2016 at 03:49:01PM +0800, Eva Rachel Retuya wrote: > On Sun, Oct 30, 2016 at 06:49:00PM +0000, Jonathan Cameron wrote: > > On 30/10/16 17:46, Lars-Peter Clausen wrote: > > > On 10/30/2016 06:41 PM, Jonathan Cameron wrote: > > >> On 28/10/16 09:26, Eva Rachel Retuya wrote: > > >>> Introduce defines for shifting and mask under the config register for > > >>> better readability. Also, introduce helper variables for index > > >>> calculation. > > >>> > > >>> Signed-off-by: Eva Rachel Retuya > > >> Looks good to me. > > >> > > >> Lars could you sanity check this one as well? > > > > > > Acked-by: Lars-Peter Clausen > > There was a bit of fun applying this. Eva, can you check I didn't mess it > > up? > > It looks fine to me. Thanks! > Have to retract that statement, I rebased and went through the merge conflict. Extra whitespace can be seen after the statement in line 644: *val = ad7746_cap_filter_rate_table[idx][0]; What to do? Eva > > > > Applied to the togreg branch of iio.git. Initially pushed out as testing > > for the autobuilders to play with it. (and this time I remembered to actually > > do the push!) > > > > thanks, > > > > Jonathan > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > >