Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762121AbcJaIOy convert rfc822-to-8bit (ORCPT ); Mon, 31 Oct 2016 04:14:54 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:46786 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762047AbcJaIOv (ORCPT ); Mon, 31 Oct 2016 04:14:51 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.56 with qID u9V8ERC4020046, This message is accepted by code: ctloc85258 From: Hayes Wang To: David Miller , "mlord@pobox.com" CC: nic_swsd , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH net] r8152: Fix broken RX checksums. Thread-Topic: [PATCH net] r8152: Fix broken RX checksums. Thread-Index: AQHSMypesTCefyf3Q0+uiksQ3ScZXKDCK5vw Date: Mon, 31 Oct 2016 08:14:27 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB201047353@RTITMBSV03.realtek.com.tw> References: <9fb6be7b-95f3-6e59-c0f4-1d6c3357416d@pobox.com> <20161030.205755.1198665157526465556.davem@davemloft.net> <1f847ae0-4928-01e7-f1e7-3cbc37529961@pobox.com> <20161030.235342.134481656830778556.davem@davemloft.net> In-Reply-To: <20161030.235342.134481656830778556.davem@davemloft.net> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.128] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1271 Lines: 31 > >>> The r8152 driver has been broken since (approx) 3.16.xx > >>> when support was added for hardware RX checksums > >>> on newer chip versions. Symptoms include random > >>> segfaults and silent data corruption over NFS. > >>> > >>> The hardware checksum logig does not work on the VER_02 > >>> dongles I have here when used with a slow embedded system CPU. > >>> Google reveals others reporting similar issues on Raspberry Pi. > >>> > >>> So, disable hardware RX checksum support for VER_02, and fix > >>> an obvious coding error for IPV6 checksums in the same function. > >>> > >>> Because this bug results in silent data corruption, > >>> it is a good candidate for back-porting to -stable >= 3.16.xx. > >>> > >>> Signed-off-by: Mark Lord > >> > >> Applied and queued up for -stable, thanks. > > > > Thanks. Now that this is taken care of, I do wonder if perhaps > > RX checksums ought to be enabled at all for ANY versions of this chip? > > You should really start a dialogue with the developer who has been > making the most, if not all, of the major changes to this driver over > the past few years, Hayes Wang. Our hw engineer says only VER_01 has the issue about rx checksum. I need more information for checking it. Best Regards, Hayes