Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763887AbcJaJYc (ORCPT ); Mon, 31 Oct 2016 05:24:32 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34118 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1763714AbcJaJYa (ORCPT ); Mon, 31 Oct 2016 05:24:30 -0400 Date: Mon, 31 Oct 2016 10:24:20 +0100 From: Heiko Carstens To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Bjorn Helgaas , Christian Borntraeger , Cornelia Huck , Gerald Schaefer , linux-s390@vger.kernel.org, Martin Schwidefsky , Peter Oberparleiter , Sebastian Ott Subject: Re: [PATCH 0/9] s390: remove modular usage from non-modular code References: <20161030203732.26405-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161030203732.26405-1-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16103109-0024-0000-0000-0000023E7A89 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16103109-0025-0000-0000-000020FDEBE1 Message-Id: <20161031092420.GA4434@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-31_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610310124 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1565 Lines: 32 On Sun, Oct 30, 2016 at 04:37:23PM -0400, Paul Gortmaker wrote: > My ongoing audit looking for non-modular code that needlessly uses > modular macros (vs. built-in equivalents) and/or has dead code > relating to module unloading that can never be executed led to the > creation of these s390 related commits. > > For anyone new to the underlying goal of this cleanup, we are trying to > not use module support for code that can never be built as a module since: > > (1) it is easy to accidentally write unused module_exit and remove code > (2) it can be misleading when reading the source, thinking it can be > modular when the Makefile and/or Kconfig prohibit it > (3) it requires the include of the module.h header file which in turn > includes nearly everything else, thus adding to CPP overhead. > (4) it gets copied/replicated into other code and spreads like weeds. > > Build tested on current linux-next (allyes/allno/allmod) to ensure no > silly typos or implicit include issues that would break compilation > crept in. > > Paul Gortmaker (9): > s390: cio: make it explicitly non-modular > s390: char: make zcore explicitly non-modular > s390: char: make con3215 explicitly non-modular > s390: char: make sclp_tty explicitly non-modular > s390: char: make slcp_quiesce explicitly non-modular > s390: hotplug: make pci_hpc explicitly non-modular > s390: hypfs: make inode explicitly non-modular > s390: kernel: make lgr explicitly non-modular > s390: virtio: make ccw explicitly non-modular Whole series applied. Thanks!