Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763915AbcJaJa3 (ORCPT ); Mon, 31 Oct 2016 05:30:29 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:36219 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763785AbcJaJa1 (ORCPT ); Mon, 31 Oct 2016 05:30:27 -0400 Date: Mon, 31 Oct 2016 10:30:21 +0100 From: Richard Cochran To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/15] ptp: use permission-specific DEVICE_ATTR variants Message-ID: <20161031093021.GA10489@localhost.localdomain> References: <1477769829-22230-1-git-send-email-Julia.Lawall@lip6.fr> <1477769829-22230-13-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477769829-22230-13-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 265 Lines: 6 On Sat, Oct 29, 2016 at 09:37:06PM +0200, Julia Lawall wrote: > Use DEVICE_ATTR_RO for read only attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. Acked-by: Richard Cochran