Date: Mon, 31 Oct 2016 10:05:23 +0000
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>, Baoyou Xie <baoyou.xie@linaro.org>,
        tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        han.fei@zte.com.cn
Subject: Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible
Message-ID: <20161031100523.GY1041@n2100.armlinux.org.uk>
References: <1477127682-3615-1-git-send-email-baoyou.xie@linaro.org>
 <5367505.BUI00TSeFs@wuerfel>
 <20161024142745.GQ20761@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161024142745.GQ20761@phenom.ffwll.local>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1148
Lines: 26

On Mon, Oct 24, 2016 at 04:27:45PM +0200, Daniel Vetter wrote:
> On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote:
> > On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote:
> > > We get 1 warning when building kernel with W=1:
> > > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
> > > 
> > > In fact, this function is only used in the file in which it is
> > > declared and don't need a declaration, but can be made static.
> > > So this patch marks this function with 'static'.
> > > 
> > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> > > 
> > 
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> Applied to drm-misc, thanks.

Argh.  This conflicts with my patch series posted before I went away,
so now we're going to end up with merge conflicts... I suppose you're
happy to handle the conflict as you've bypassed waiting for an ack
from the driver maintainer...

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.