Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938581AbcJaK4M (ORCPT ); Mon, 31 Oct 2016 06:56:12 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44441 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935153AbcJaK4L (ORCPT ); Mon, 31 Oct 2016 06:56:11 -0400 Date: Mon, 31 Oct 2016 11:56:00 +0100 From: Cornelia Huck To: Paul Gortmaker Cc: , Christian Borntraeger , Martin Schwidefsky , Heiko Carstens , Subject: Re: [PATCH 9/9] s390: virtio: make ccw explicitly non-modular In-Reply-To: <20161030203732.26405-10-paul.gortmaker@windriver.com> References: <20161030203732.26405-1-paul.gortmaker@windriver.com> <20161030203732.26405-10-paul.gortmaker@windriver.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16103110-0032-0000-0000-0000023413E6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16103110-0033-0000-0000-00001D826C5D Message-Id: <20161031115600.0a0830e2.cornelia.huck@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-31_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610310124 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 41 On Sun, 30 Oct 2016 16:37:32 -0400 Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > arch/s390/Kconfig:config S390_GUEST > arch/s390/Kconfig: def_bool y > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We replace module.h with moduleparam.h since the file does declare > some module_param() and leaving that as-is is currently the easiest > way to remain compatible with existing boot arg use cases. > > Cc: Christian Borntraeger > Cc: Cornelia Huck > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s390@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/s390/virtio/virtio_ccw.c | 25 ++----------------------- > 1 file changed, 2 insertions(+), 23 deletions(-) There might actually be a case for making this modular, as the virtio-pci transport can be built as a module as well. But I don't think anybody really cares, and your patch is easily reverted should we want to do this later, so Acked-by: Cornelia Huck [going through the s390 tree with the other patches is probably easier as taking this through the virtio tree]