Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938583AbcJaLA5 (ORCPT ); Mon, 31 Oct 2016 07:00:57 -0400 Received: from mail-db5eur01on0058.outbound.protection.outlook.com ([104.47.2.58]:15583 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935064AbcJaLAx (ORCPT ); Mon, 31 Oct 2016 07:00:53 -0400 From: "Y.B. Lu" To: Arnd Bergmann , "linuxppc-dev@lists.ozlabs.org" CC: "linux-mmc@vger.kernel.org" , "ulf.hansson@linaro.org" , Scott Wood , Mark Rutland , Greg Kroah-Hartman , "X.B. Xie" , "M.H. Lian" , "linux-i2c@vger.kernel.org" , "linux-clk@vger.kernel.org" , Qiang Zhao , Russell King , Bhupesh Sharma , Joerg Roedel , Claudiu Manoil , "devicetree@vger.kernel.org" , Rob Herring , "Santosh Shilimkar" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , "iommu@lists.linux-foundation.org" , "Kumar Gala" , Geert Uytterhoeven Subject: RE: [v15, 6/7] base: soc: introduce soc_device_match() interface Thread-Topic: [v15, 6/7] base: soc: introduce soc_device_match() interface Thread-Index: AQHSMOl0GfX/s3pmsES3T7YREh3DLKC9r6YAgASgvgA= Date: Mon, 31 Oct 2016 09:28:56 +0000 Message-ID: References: <1477637418-38938-1-git-send-email-yangbo.lu@nxp.com> <1477637418-38938-7-git-send-email-yangbo.lu@nxp.com> <2572890.e6aV4hmMEL@wuerfel> In-Reply-To: <2572890.e6aV4hmMEL@wuerfel> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yangbo.lu@nxp.com; x-originating-ip: [199.59.225.131] x-ms-office365-filtering-correlation-id: 56149363-112c-4eaa-a8c6-08d401705689 x-microsoft-exchange-diagnostics: 1;DB6PR0401MB2423;7:YmetDLIJ+hMQtcSYwBqHdvQFoIbLUuSP3Z1DpAZDeZzrVDtQ9IDG64UtJlvLkiwXaScgGvfb9CZJev4WSVt0o7R9+r9UD1n6qvjeUUF1BbmEGSLeHIEVtHscgGfNbsAONV7AXvqqogxsObPchUEf3mPXvX3zLAd+3iBu+3gWHecgqo676uu1fs6j0WBjH6cDk/+Ei4ZWiBwIGMtYWedX3hZ4MBV38pxkrMzXAQWZKajP8oUUaJNjdvJk2z25VWK0iIgkDdHq/yhtxDjrE2FaDqG+fZaa25OY25jcFPxka1LWBqA4qQX5p78m0FcWcgTIgffF7watG9BSenJ15dYyjub1uoMVB1BTeYvcYA8o6U0= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2423; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(65623756079841)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6045074)(6040176)(6060202)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6046074)(6072074);SRVR:DB6PR0401MB2423;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0401MB2423; x-forefront-prvs: 01128BA907 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(24454002)(199003)(13464003)(377454003)(189002)(9686002)(74316002)(102836003)(66066001)(3660700001)(6116002)(7416002)(7736002)(92566002)(7846002)(86362001)(305945005)(122556002)(19580405001)(19580395003)(3280700002)(5002640100001)(3846002)(81156014)(81166006)(68736007)(586003)(8676002)(189998001)(105586002)(106356001)(106116001)(101416001)(11100500001)(54356999)(76176999)(50986999)(2900100001)(15975445007)(77096005)(76576001)(33656002)(97736004)(8936002)(5001770100001)(2906002)(2501003)(4326007)(87936001)(2950100002)(7696004)(10400500002)(5660300001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0401MB2423;H:DB6PR0401MB2536.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2016 09:28:56.3097 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2423 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9VB12f3028248 Content-Length: 1516 Lines: 39 > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Friday, October 28, 2016 6:48 PM > To: linuxppc-dev@lists.ozlabs.org > Cc: Y.B. Lu; linux-mmc@vger.kernel.org; ulf.hansson@linaro.org; Scott > Wood; Mark Rutland; Greg Kroah-Hartman; X.B. Xie; M.H. Lian; linux- > i2c@vger.kernel.org; linux-clk@vger.kernel.org; Qiang Zhao; Russell King; > Bhupesh Sharma; Joerg Roedel; Claudiu Manoil; devicetree@vger.kernel.org; > Rob Herring; Santosh Shilimkar; linux-arm-kernel@lists.infradead.org; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Leo Li; > iommu@lists.linux-foundation.org; Kumar Gala; Geert Uytterhoeven > Subject: Re: [v15, 6/7] base: soc: introduce soc_device_match() interface > > On Friday, October 28, 2016 2:50:17 PM CEST Yangbo Lu wrote: > > + > > +static int soc_device_match_one(struct device *dev, void *arg) { > > + struct soc_device *soc_dev = container_of(dev, struct > soc_device, dev); > > + const struct soc_device_attribute *match = arg; > > + > > + if (match->machine && > > + !glob_match(match->machine, soc_dev->attr->machine)) > > + return 0; > > + > > + if (match->family && > > + !glob_match(match->family, soc_dev->attr->family)) > > + return 0; > > + > > > > Geert found a bug in my code, and submitted a fix at > https://patchwork.kernel.org/patch/9361395/ > > I think you should include that one in your series. > [Lu Yangbo-B47093] Ok, no problem. Thanks :) > Arnd