Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941264AbcJaLpq (ORCPT ); Mon, 31 Oct 2016 07:45:46 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33740 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935873AbcJaLpn (ORCPT ); Mon, 31 Oct 2016 07:45:43 -0400 Subject: Re: [PATCH 2/2] mm: remove get_user_pages_locked() To: Lorenzo Stoakes , linux-mm@kvack.org References: <20161031100228.17917-1-lstoakes@gmail.com> <20161031100228.17917-3-lstoakes@gmail.com> Cc: Linus Torvalds , Michal Hocko , Jan Kara , Hugh Dickins , Dave Hansen , Rik van Riel , Mel Gorman , Andrew Morton , linux-kernel@vger.kernel.org, linux-cris-kernel@axis.com, linux-ia64@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, kvm@vger.kernel.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org From: Paolo Bonzini Message-ID: Date: Mon, 31 Oct 2016 12:45:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161031100228.17917-3-lstoakes@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 635 Lines: 18 On 31/10/2016 11:02, Lorenzo Stoakes wrote: > - * > - * get_user_pages should be phased out in favor of > - * get_user_pages_locked|unlocked or get_user_pages_fast. Nothing > - * should use get_user_pages because it cannot pass > - * FAULT_FLAG_ALLOW_RETRY to handle_mm_fault. This comment should be preserved in some way. In addition, removing get_user_pages_locked() makes it harder (compared to a simple "git grep -w") to identify callers that lack allow-retry functionality). So I'm not sure about the benefits of these patches. If all callers were changed, then sure removing the _locked suffix would be a good idea. Paolo