Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941297AbcJaLuR (ORCPT ); Mon, 31 Oct 2016 07:50:17 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:1603 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941198AbcJaLuO (ORCPT ); Mon, 31 Oct 2016 07:50:14 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Sun, 30 Oct 2016 16:50:05 -0700 Subject: Re: [PATCH] drm/tegra: dpaux: Fix error handling To: Christophe JAILLET , , , , , References: <20161028090945.11573-1-christophe.jaillet@wanadoo.fr> CC: , , , From: Jon Hunter Message-ID: Date: Mon, 31 Oct 2016 10:14:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161028090945.11573-1-christophe.jaillet@wanadoo.fr> X-Originating-IP: [10.21.132.110] X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 41 On 28/10/16 10:09, Christophe JAILLET wrote: > 'devm_pinctrl_register()' returns an error pointer or a valid handle. So > checking for NULL here is pointless and can never trigger. > > Check the returned value with IS_ERR instead and propagate this value as > done in the other functions which call 'devm_pinctrl_register()' > > Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support") > > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/tegra/dpaux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c > index 059f409556d5..2fde44c3a1b3 100644 > --- a/drivers/gpu/drm/tegra/dpaux.c > +++ b/drivers/gpu/drm/tegra/dpaux.c > @@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev) > dpaux->desc.owner = THIS_MODULE; > > dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux); > - if (!dpaux->pinctrl) { > + if (IS_ERR(dpaux->pinctrl)) { > dev_err(&pdev->dev, "failed to register pincontrol\n"); > - return -ENODEV; > + return PTR_ERR(dpaux->pinctrl); > } > #endif > /* enable and clear all interrupts */ Thanks for the fix! Acked-by: Jon Hunter Cheers Jon -- nvpublic