Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941430AbcJaMRF (ORCPT ); Mon, 31 Oct 2016 08:17:05 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:44935 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941412AbcJaMQ7 (ORCPT ); Mon, 31 Oct 2016 08:16:59 -0400 From: Zubair Lutfullah Kakakhel To: , , , CC: , , , , Subject: [Patch V6 5/6] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided Date: Mon, 31 Oct 2016 12:16:46 +0000 Message-ID: <1477916207-25157-6-git-send-email-Zubair.Kakakhel@imgtec.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1477916207-25157-1-git-send-email-Zubair.Kakakhel@imgtec.com> References: <1477916207-25157-1-git-send-email-Zubair.Kakakhel@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.154.45] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 33 The powerpc dts file upstream does not have the xlnx,kind-of-intr property. Instead of erroring out, give a warning instead. And attempt to continue to probe the interrupt controller while assuming kind-of-intr is 0x0 as a fall back. Signed-off-by: Zubair Lutfullah Kakakhel --- V5 -> V6 Rebase to v4.9-rc3 V5 new patch --- drivers/irqchip/irq-xilinx-intc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-xilinx-intc.c b/drivers/irqchip/irq-xilinx-intc.c index ea15446..954e9b4 100644 --- a/drivers/irqchip/irq-xilinx-intc.c +++ b/drivers/irqchip/irq-xilinx-intc.c @@ -200,8 +200,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc, ret = of_property_read_u32(intc, "xlnx,kind-of-intr", &irqc->intr_mask); if (ret < 0) { - pr_err("irq-xilinx: unable to read xlnx,kind-of-intr\n"); - goto err_alloc; + pr_warn("irq-xilinx: unable to read xlnx,kind-of-intr\n"); + irqc->intr_mask = 0; } if (irqc->intr_mask >> nr_irq) -- 1.9.1