Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943927AbcJaPLa (ORCPT ); Mon, 31 Oct 2016 11:11:30 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:50333 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943885AbcJaPL2 (ORCPT ); Mon, 31 Oct 2016 11:11:28 -0400 Date: Mon, 31 Oct 2016 08:11:23 -0700 From: Christoph Hellwig To: "Theodore Ts'o" , Ming Lei , Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , "Kirill A . Shutemov" , Mike Christie , Hannes Reinecke , Keith Busch , Mike Snitzer , Johannes Thumshirn , Bart Van Assche Subject: Re: [PATCH 45/60] block: bio: introduce bio_for_each_segment_all_rd() and its write pair Message-ID: <20161031151123.GA3193@infradead.org> References: <1477728600-12938-1-git-send-email-tom.leiming@gmail.com> <1477728600-12938-46-git-send-email-tom.leiming@gmail.com> <20161031135943.36crigad55hwmmrl@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161031135943.36crigad55hwmmrl@thunk.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 431 Lines: 8 On Mon, Oct 31, 2016 at 09:59:43AM -0400, Theodore Ts'o wrote: > What is _rd and _wt supposed to stand for? I think it's read and write, but I think the naming is highly unfortunate. I started dabbling around with the patches a bit, and to keep my sanity a started reaming it to _pages and _bvec which is the real semantics - the _rd or _pages gives you a synthetic bvec for each page, and the other one gives you the full bvec.