Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944026AbcJaPZ4 (ORCPT ); Mon, 31 Oct 2016 11:25:56 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53335 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943729AbcJaPZw (ORCPT ); Mon, 31 Oct 2016 11:25:52 -0400 Date: Mon, 31 Oct 2016 08:25:49 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , "Kirill A . Shutemov" , Philipp Reisner , Lars Ellenberg , "open list:DRBD DRIVER" Subject: Re: [PATCH 03/60] block: drbd: remove impossible failure handling Message-ID: <20161031152549.GA30919@infradead.org> References: <1477728600-12938-1-git-send-email-tom.leiming@gmail.com> <1477728600-12938-4-git-send-email-tom.leiming@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477728600-12938-4-git-send-email-tom.leiming@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 420 Lines: 13 On Sat, Oct 29, 2016 at 04:08:02PM +0800, Ming Lei wrote: > For a non-cloned bio, bio_add_page() only returns failure when > the io vec table is full, but in that case, bio->bi_vcnt can't > be zero at all. > > So remove the impossible failure handling. > > Acked-by: Lars Ellenberg > Signed-off-by: Ming Lei Looks good, Reviewed-by: Christoph Hellwig