Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944056AbcJaP0V (ORCPT ); Mon, 31 Oct 2016 11:26:21 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53438 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943791AbcJaP0T (ORCPT ); Mon, 31 Oct 2016 11:26:19 -0400 Date: Mon, 31 Oct 2016 08:26:16 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , "Kirill A . Shutemov" , Jiri Kosina , Mike Christie , Hannes Reinecke , Dan Williams Subject: Re: [PATCH 04/60] block: floppy: use bio_add_page() Message-ID: <20161031152616.GB30919@infradead.org> References: <1477728600-12938-1-git-send-email-tom.leiming@gmail.com> <1477728600-12938-5-git-send-email-tom.leiming@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477728600-12938-5-git-send-email-tom.leiming@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 82 Lines: 2 Why not keep the bio_add_page in the same spot as direct assignments were before?