Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944172AbcJaPaC (ORCPT ); Mon, 31 Oct 2016 11:30:02 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:54060 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943920AbcJaP36 (ORCPT ); Mon, 31 Oct 2016 11:29:58 -0400 Date: Mon, 31 Oct 2016 08:29:57 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , "Kirill A . Shutemov" , Joern Engel , Prasad Joshi , "open list:LogFS" Subject: Re: [PATCH 13/60] fs: logfs: remove unnecesary check Message-ID: <20161031152957.GG30919@infradead.org> References: <1477728600-12938-1-git-send-email-tom.leiming@gmail.com> <1477728600-12938-14-git-send-email-tom.leiming@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477728600-12938-14-git-send-email-tom.leiming@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 178 Lines: 6 On Sat, Oct 29, 2016 at 04:08:12PM +0800, Ming Lei wrote: > The check on bio->bi_vcnt doesn't make sense in erase_end_io(). Agreed, Reviewed-by: Christoph Hellwig