Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944272AbcJaPjT (ORCPT ); Mon, 31 Oct 2016 11:39:19 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56124 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S944051AbcJaPjR (ORCPT ); Mon, 31 Oct 2016 11:39:17 -0400 Date: Mon, 31 Oct 2016 08:39:15 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , "Kirill A . Shutemov" , Jens Axboe , Hannes Reinecke , Mike Christie , Dan Williams , Toshi Kani , Kent Overstreet Subject: Re: [PATCH 28/60] block: introduce QUEUE_FLAG_SPLIT_MP Message-ID: <20161031153915.GL30919@infradead.org> References: <1477728600-12938-1-git-send-email-tom.leiming@gmail.com> <1477728600-12938-29-git-send-email-tom.leiming@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477728600-12938-29-git-send-email-tom.leiming@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 14 On Sat, Oct 29, 2016 at 04:08:27PM +0800, Ming Lei wrote: > Some drivers(such as dm) should be capable of dealing with multipage > bvec, but the incoming bio may be too big, such as, a new singlepage bvec > bio can't be cloned from the bio, or can't be allocated to singlepage > bvec with same size. > > At least crypt dm, log writes and bcache have this kind of issue. We already have the segment_size limitation for request based drivers. I'd rather extent it to bio drivers if really needed. But then again we should look into not having this limitation. E.g. for bcache I'd be really surprised if it's that limited, given that Kent came up with this whole multipage bvec scheme.