Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944328AbcJaPpQ (ORCPT ); Mon, 31 Oct 2016 11:45:16 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:39516 "EHLO albert.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S944161AbcJaPpN (ORCPT ); Mon, 31 Oct 2016 11:45:13 -0400 From: Geert Uytterhoeven To: Konrad Rzeszutek Wilk , Jonathan Corbet Cc: Magnus Damm , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, iommu@lists.linux-foundation.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 1/2] swiotlb: Rate-limit printing when running out of SW-IOMMU space Date: Mon, 31 Oct 2016 16:45:03 +0100 Message-Id: <1477928704-10611-2-git-send-email-geert+renesas@glider.be> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1477928704-10611-1-git-send-email-geert+renesas@glider.be> References: <1477928704-10611-1-git-send-email-geert+renesas@glider.be> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 30 If the system runs out of SW-IOMMU space, changes are high successive requests will fail, too, flooding the kernel log. This is true especially for streaming DMA, which is typically used repeatedly outside the driver's initialization routine. Add rate-limiting to fix this. While at it, get rid of the open-coded dev_name() handling by using the appropriate dev_err_*() variant. Signed-off-by: Geert Uytterhoeven --- lib/swiotlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 22e13a0e19d76a2b..6ce764410ae475cc 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -714,8 +714,8 @@ void swiotlb_tbl_sync_single(struct device *hwdev, phys_addr_t tlb_addr, * When the mapping is small enough return a static buffer to limit * the damage, or panic when the transfer is too big. */ - printk(KERN_ERR "DMA: Out of SW-IOMMU space for %zu bytes at " - "device %s\n", size, dev ? dev_name(dev) : "?"); + dev_err_ratelimited(dev, "DMA: Out of SW-IOMMU space for %zu bytes\n", + size); if (size <= io_tlb_overflow || !do_panic) return; -- 1.9.1