From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: "'Larry Finger'" <Larry.Finger@lwfinger.net>,
        Linus Torvalds <torvalds@linux-foundation.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "driver-devel@vger.kernel.org" <driver-devel@vger.kernel.org>
Subject: RE: [PATCH] drm/radeon: Fix kernel panic on shutdown
Thread-Topic: [PATCH] drm/radeon: Fix kernel panic on shutdown
Thread-Index: AQHSMzD6j50LovuSJUuNWD2bObd4SqDCv1gA
Date: Mon, 31 Oct 2016 16:21:55 +0000
Message-ID: <MWHPR12MB1694E2F1EF8B572991416EE3F7AE0@MWHPR12MB1694.namprd12.prod.outlook.com>
References: <20161031044053.24955-1-Larry.Finger@lwfinger.net>
In-Reply-To: <20161031044053.24955-1-Larry.Finger@lwfinger.net>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2016 16:21:55.9619
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1693
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9VGaMNH029870
Content-Length: 2031
Lines: 53

> -----Original Message-----
> From: Larry Finger [mailto:larry.finger@gmail.com] On Behalf Of Larry Finger
> Sent: Monday, October 31, 2016 12:41 AM
> To: Linus Torvalds
> Cc: linux-kernel@vger.kernel.org; driver-devel@vger.kernel.org; Larry
> Finger; Deucher, Alexander
> Subject: [PATCH] drm/radeon: Fix kernel panic on shutdown
> 
> Since commit a481daa88fd4 ("drm/radeon: always apply pci shutdown
> callbacks"), a Dell Latitude D600 laptop has crashed on shutdown. The
> PCI Identification of the graphics adapter is "VGA compatible controller
> [0300]: Advanced Micro Devices, Inc. [AMD/ATI] RV250/M9 GL [Mobility
> FireGL 9000/Radeon 9000] [1002:4c66] (rev 01)".
> 
> Prior to commit b0c80bd5d2e3 ("drm/radeon: fix up dp aux tear down (v2)"),
> I have no idea where the panic happened as the screen was blanked before
> the crash.  Since that more recent change, the panic has been in routine
> radeon_connector_unregister(), and has been shown to be due to a NULL
> value in the ddc_bus member of struct drm_connector.
> 
> Fixes: a481daa88fd4 ("drm/radeon: always apply pci shutdown callbacks")
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_connectors.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
> b/drivers/gpu/drm/radeon/radeon_connectors.c
> index e18839d..27affbd 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -931,7 +931,7 @@ static void radeon_connector_unregister(struct
> drm_connector *connector)
>  {
>  	struct radeon_connector *radeon_connector =
> to_radeon_connector(connector);
> 
> -	if (radeon_connector->ddc_bus->has_aux) {
> +	if (radeon_connector->ddc_bus && radeon_connector->ddc_bus-
> >has_aux) {
>  		drm_dp_aux_unregister(&radeon_connector->ddc_bus-
> >aux);
>  		radeon_connector->ddc_bus->has_aux = false;
>  	}
> --
> 2.10.0