Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S946651AbcJaUa0 (ORCPT ); Mon, 31 Oct 2016 16:30:26 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35312 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S946342AbcJaUaX (ORCPT ); Mon, 31 Oct 2016 16:30:23 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Matt Ranostay Subject: Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Date: Mon, 31 Oct 2016 21:30:20 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-100-generic; KDE/4.14.2; x86_64; ; ) Cc: Matt Ranostay , Pavel Machek , Sebastian Reichel , kernel list , "linux-arm-kernel" , Linux OMAP List , Tony Lindgren , khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com References: <1475092512-30555-1-git-send-email-matt@ranostay.consulting> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart9129222.Ux6CIOLuVt"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201610312130.20261@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 43 --nextPart9129222.Ux6CIOLuVt Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Monday 31 October 2016 21:22:18 Matt Ranostay wrote: > On Tue, Oct 25, 2016 at 11:47 AM, Matt Ranostay > wrote: > > On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek wrote: > >> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote: > >>> Pavel + Sebastian this is the patchset that need I some input on > >>> :) > >>=20 > >> Better then previous one. > >=20 > >> But my version of bq27xxx_battery.c already contains this: > > This is for allowing udev rule to set the properties as well. > > otherwise a kinda crude RUN =3D " echo value > > > /sys/module/bq27xxx_battery/parameters/poll_interval" is required. >=20 > Any thoughts on this? Isn't sysfs /sys/module/bq27xxx_battery/parameters/poll_interval=20 attribute what should be used to change module parameters like=20 poll_interval? =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart9129222.Ux6CIOLuVt Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlgXqdwACgkQi/DJPQPkQ1LAxwCePYQE5tWLGJ3XWUdiuvysls4/ UbYAoLgORj9Pe/Ahm9IDRyuOEwq7CnvF =zNIO -----END PGP SIGNATURE----- --nextPart9129222.Ux6CIOLuVt--