Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S947151AbcJaV0F (ORCPT ); Mon, 31 Oct 2016 17:26:05 -0400 Received: from mail-ua0-f193.google.com ([209.85.217.193]:35536 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S947100AbcJaV0D (ORCPT ); Mon, 31 Oct 2016 17:26:03 -0400 MIME-Version: 1.0 In-Reply-To: <1477942639-109971-2-git-send-email-hare@suse.de> References: <1477942639-109971-1-git-send-email-hare@suse.de> <1477942639-109971-2-git-send-email-hare@suse.de> From: Ming Lei Date: Tue, 1 Nov 2016 05:26:02 +0800 Message-ID: Subject: Re: [PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity To: Hannes Reinecke Cc: Jens Axboe , Christoph Hellwig , Alexander Graf , Ming@suse.de, <"Lei , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1256 Lines: 35 On Tue, Nov 1, 2016 at 3:37 AM, Hannes Reinecke wrote: > Signed-off-by: Hannes Reinecke > Reviewed-by: Christoph Hellwig > --- > drivers/block/loop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index fa1b7a9..3008dec 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -1298,7 +1298,7 @@ loop_get_status64(struct loop_device *lo, struct loop_info64 __user *arg) { > return err; > } > > -static int loop_set_capacity(struct loop_device *lo, struct block_device *bdev) > +static int loop_set_capacity(struct loop_device *lo) > { > if (unlikely(lo->lo_state != Lo_bound)) > return -ENXIO; > @@ -1361,7 +1361,7 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode, > case LOOP_SET_CAPACITY: > err = -EPERM; > if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN)) > - err = loop_set_capacity(lo, bdev); > + err = loop_set_capacity(lo); > break; > case LOOP_SET_DIRECT_IO: > err = -EPERM; Reviewed-by: Ming Lei thanks, Ming Lei