Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S947279AbcJaVi4 (ORCPT ); Mon, 31 Oct 2016 17:38:56 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:44928 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S947218AbcJaViu (ORCPT ); Mon, 31 Oct 2016 17:38:50 -0400 Date: Mon, 31 Oct 2016 22:38:46 +0100 From: Pavel Machek To: Matt Ranostay Cc: Matt Ranostay , pali.rohar@gmail.com, Sebastian Reichel , kernel list , linux-arm-kernel , Linux OMAP List , Tony Lindgren , khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com Subject: Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Message-ID: <20161031213846.GA21014@amd> References: <1475092512-30555-1-git-send-email-matt@ranostay.consulting> <1475092512-30555-3-git-send-email-matt@ranostay.consulting> <20161024201443.GB5989@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="G4iJoqBmSsgzjUCe" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1553 Lines: 50 --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2016-10-31 13:22:18, Matt Ranostay wrote: > On Tue, Oct 25, 2016 at 11:47 AM, Matt Ranostay wro= te: > > On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek wrote: > >> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote: > >>> Pavel + Sebastian this is the patchset that need I some input on :) > >> > >> Better then previous one. > >> > >> But my version of bq27xxx_battery.c already contains this: > > > > This is for allowing udev rule to set the properties as well. > > otherwise a kinda crude RUN =3D " echo value > > > /sys/module/bq27xxx_battery/parameters/poll_interval" is required. >=20 > Any thoughts on this? =20 I'd say echo value > /sys/module/bq27xxx_battery/parameters/poll_interval .. is quite adequate solution...? Alternatively, convince us that something else is useful for everyone, and we can do the right thing (poll more often when battery is nearly empty), automatically... Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --G4iJoqBmSsgzjUCe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlgXueYACgkQMOfwapXb+vI3oQCdGKxyRFiw0nOfAQjZNqut6C6b mykAoMH32yVKtlaovynPOf5IXTkcOBED =gMOS -----END PGP SIGNATURE----- --G4iJoqBmSsgzjUCe--