Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S948147AbcKAAVZ (ORCPT ); Mon, 31 Oct 2016 20:21:25 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36062 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S948116AbcKAAVY (ORCPT ); Mon, 31 Oct 2016 20:21:24 -0400 Date: Mon, 31 Oct 2016 17:21:22 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Piotr Kwapulinski cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, vbabka@suse.cz, mhocko@suse.com, liangchen.linux@gmail.com, mgorman@techsingularity.net, dave.hansen@linux.intel.com, nzimmer@sgi.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v3 0/1] mm/mempolicy.c: forbid static or relative flags for local NUMA mode In-Reply-To: <20161027163037.4089-1-kwapulinski.piotr@gmail.com> Message-ID: References: <20160927132532.12110-1-kwapulinski.piotr@gmail.com> <20161027163037.4089-1-kwapulinski.piotr@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 17 On Thu, 27 Oct 2016, Piotr Kwapulinski wrote: > The MPOL_F_STATIC_NODES and MPOL_F_RELATIVE_NODES flags are irrelevant > when setting them for MPOL_LOCAL NUMA memory policy via set_mempolicy > or mbind. > Return the "invalid argument" from set_mempolicy and mbind whenever > any of these flags is passed along with MPOL_LOCAL. > It is consistent with MPOL_PREFERRED passed with empty nodemask. > It slightly shortens the execution time in paths where these flags > are used e.g. when trying to rebind the NUMA nodes for changes in > cgroups cpuset mems (mpol_rebind_preferred()) or when just printing > the mempolicy structure (/proc/PID/numa_maps). > Isolated tests done. > > Signed-off-by: Piotr Kwapulinski Acked-by: David Rientjes