Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163109AbcKAF5u (ORCPT ); Tue, 1 Nov 2016 01:57:50 -0400 Received: from 11.mo3.mail-out.ovh.net ([87.98.184.158]:59006 "EHLO 11.mo3.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754351AbcKAF5r (ORCPT ); Tue, 1 Nov 2016 01:57:47 -0400 Date: Tue, 1 Nov 2016 06:57:23 +0100 From: Lukasz Majewski To: Sascha Hauer Cc: Boris Brezillon , linux-pwm@vger.kernel.org, Bhuvanchandra DV , linux-kernel@vger.kernel.org, Stefan Agner , Thierry Reding , kernel@pengutronix.de, Fabio Estevam , Philipp Zabel , Fabio Estevam , Lothar Wassmann Subject: Re: [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic pwm operation Message-ID: <20161101065723.7751a55e@jawa> In-Reply-To: <20161031092937.im5epytgorcd5fbm@pengutronix.de> References: <1477549785-4972-1-git-send-email-l.majewski@majess.pl> <1477549785-4972-4-git-send-email-l.majewski@majess.pl> <20161027094005.2da3b7d4@bbrezillon> <20161031055904.av45k535c26gjonz@pengutronix.de> <20161031092937.im5epytgorcd5fbm@pengutronix.de> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/Z9jgMB00z=K.2nuQ9beEMQi"; protocol="application/pgp-signature" X-Ovh-Tracer-Id: 3375729395850330768 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelvddrkedtgdeklecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 31 --Sig_/Z9jgMB00z=K.2nuQ9beEMQi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Sascha, > The current assumption as discussed by Philipp and me is that the ipg > clk is only needed when the pwm output is driven by the ipg clk > (MX3_PWMCR[16:17] =3D MX3_PWMCR_CLKSRC_IPG) At least on my setup (i.MX6q) the ipg clock (ipg_clk) don't need to be explicitly enabled in the ->apply() callback (in the pwm-imx.c) when MX3_PWMCR_CLKSRC_IPG (0x01 - ipg_clk) is selected as the PWM source. Best regards, =C5=81ukasz Majewski --Sig_/Z9jgMB00z=K.2nuQ9beEMQi Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlgYLsoACgkQf9/hG2YwgjFU9ACgzLDJYKwYcJcgeK1kZwS9f4mX KVcAoKZ8OEKkyXiy7iAUzeEwfXEMDaux =w3Eb -----END PGP SIGNATURE----- --Sig_/Z9jgMB00z=K.2nuQ9beEMQi--