Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168230AbcKAJ1u (ORCPT ); Tue, 1 Nov 2016 05:27:50 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:26115 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1168212AbcKAJ1s (ORCPT ); Tue, 1 Nov 2016 05:27:48 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Tue, 01 Nov 2016 09:26:54 +0000 From: Paul Burton To: "Maciej W. Rozycki" CC: , Ralf Baechle , Subject: Re: [PATCH 1/4] MIPS: Fix ISA I FP sigcontext access violation handling Date: Tue, 1 Nov 2016 09:27:39 +0000 Message-ID: <3679706.n1bQkNAIWn@np-p-burton> Organization: Imagination Technologies User-Agent: KMail/5.3.2 (Linux/4.8.4-1-ARCH; KDE/5.27.0; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2082248.U7eFgs0xAx"; micalg=pgp-sha256; protocol="application/pgp-signature" X-Originating-IP: [10.100.200.179] X-ESG-ENCRYPT-TAG: 1b7d744b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2367 Lines: 65 --nextPart2082248.U7eFgs0xAx Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday, 31 October 2016 16:25:44 GMT Maciej W. Rozycki wrote: > Complement commit 0ae8dceaebe3 ("Merge with 2.3.10.") and use the local > `fault' handler to recover from FP sigcontext access violation faults, > like corresponding code does in r4k_fpu.S. The `bad_stack' handler is > in syscall.c and is not suitable here as we want to propagate the error > condition up through the caller rather than killing the thread outright. > > Signed-off-by: Maciej W. Rozycki > --- > I guess it hardly ever triggers and code still builds, so it has aged so > well... > > Maciej > > linux-mips-isa1-sig-fp-context-fault.patch > Index: linux-sfr-test/arch/mips/kernel/r2300_fpu.S > =================================================================== > --- linux-sfr-test.orig/arch/mips/kernel/r2300_fpu.S 2016-10-22 > 02:36:46.000000000 +0100 +++ > linux-sfr-test/arch/mips/kernel/r2300_fpu.S 2016-10-22 02:37:20.891186000 > +0100 @@ -21,7 +21,7 @@ > #define EX(a,b) \ > 9: a,##b; \ > .section __ex_table,"a"; \ > - PTR 9b,bad_stack; \ > + PTR 9b,fault; \ > .previous > > .set noreorder Hi Maciej, Looks good to me: Reviewed-by: Paul Burton Thanks, Paul --nextPart2082248.U7eFgs0xAx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJYGGALAAoJEIIg2fppPBxl3WkQAI5HhsSeuvTTh3oKocYTAlLz JwZlV7zWmG0P6yQrVtjdzlsRhlJoF2RLpRw2rKrwvgIWkEOJUlLG1swkM7JUWcIK qK6oDSrfN/3Fo0q0P8l55XnmXB4iFx83i4Toec4OEcfl97Wp5Nlf09GTTbljP9zo GWggGSIbEIUUg+oCe6zAdrjiXo4f1iQ2eMxp1Ym2XlSmjpdhkcVBtJucvFpRodNy /VsZPZCeHcW5SFFb6wGu0U47JKfy6b7pkptzquQQpHqnH7JkSPeBO8v4ecRJTCpW VVMo+difjo3HeARKlWIR0SBtwinpdgh2WcWUkPcvq3+sbFwEeLRE7lLENnGOCQqD WoT2qhWWE293wDHdgMFGCr1CvYytJynTEdLNVLREM+Xu+0Utc4QOHVc7OvgO3eqR 09CgKuzkYzNI2DfdQaAVasKHs3qnfAq5slsjl2SYv3blIjmIvjUFkdzj82uvbune KXV61yORDknFY9RQZLO5MPSbEUvw8vRfg271r93A6r540A6t/Opk9ekESQn8EEQV E1MtVfZ6gY+c5v0v5XUksdInlePycjHcqBrP5D206C7JT22LXDHPzT11cvXmObUy G9DDZKJ6gHHqdE9pJyZrvTpkGzg5e2UMGXFjORpSiC49yex/nRnyPXNRhttyEUjv 5igexToaU7KsAG72wKuD =1ZQ6 -----END PGP SIGNATURE----- --nextPart2082248.U7eFgs0xAx--