Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423052AbcKAJnR (ORCPT ); Tue, 1 Nov 2016 05:43:17 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:59665 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422927AbcKAJnP (ORCPT ); Tue, 1 Nov 2016 05:43:15 -0400 Date: Tue, 1 Nov 2016 10:43:13 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 07/11] net: dsa: mv88e6xxx: add port link setter Message-ID: <20161101094313.GB2802@lunn.ch> References: <20161101032023.32762-1-vivien.didelot@savoirfairelinux.com> <20161101032023.32762-8-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161101032023.32762-8-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 334 Lines: 13 > +#define LINK_UNKNOWN -1 > + > + /* Port's MAC link state > + * LINK_UNKNOWN for normal link detection, 0 to force link down, > + * otherwise force link up. > + */ > + int (*port_set_link)(struct mv88e6xxx_chip *chip, int port, int link); Hi Vivien Maybe LINK_AUTO would be better than UNKNOWN? Or LINK_UNFORCED. Andrew