Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965975AbcKAMRO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 1 Nov 2016 08:17:14 -0400
Received: from mail-lf0-f67.google.com ([209.85.215.67]:34075 "EHLO
        mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965951AbcKAMRM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Nov 2016 08:17:12 -0400
MIME-Version: 1.0
In-Reply-To: <f1c8288a-7a28-da2b-1b4a-699d2effa223@infradead.org>
References: <CALyZvKyveULRX56yZz1nx96ZjDoo3JKPAFqj=29p++nx=sGHVw@mail.gmail.com>
 <3077d5cb-9a8a-5d3e-cd00-ce3ad5cb3406@infradead.org> <CALyZvKwe+NmGn=3NY=TMBtPHGYgt2KTP0G9OjO6w_gG=VDLUrg@mail.gmail.com>
 <5d04ac9f-8cf5-3f1a-4943-16dbfd24f0fc@infradead.org> <f1c8288a-7a28-da2b-1b4a-699d2effa223@infradead.org>
From: Boris Barbulovski <bbarbulovski@gmail.com>
Date: Tue, 1 Nov 2016 13:17:08 +0100
Message-ID: <CAOfo6n8EgfQacWyUnv7ax4eb4cXizcW7ZuOTn5GDZyPRs6gaSg@mail.gmail.com>
Subject: Re: please, where has xconfig KConf option documentation gone with
 linux 4.8's Qt5 / Qt4 xconfig ?
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jason Vas Dias <jason.vas.dias@gmail.com>,
        linux-kernel@vger.kernel.org,
        linux-kbuild <linux-kbuild@vger.kernel.org>,
        Thiago Macieira <thiago.macieira@intel.com>,
        Michal Marek <mmarek@suse.cz>
Content-Type: multipart/mixed; boundary=001a11402ee2bff77905403c4d74
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 6844
Lines: 160

--001a11402ee2bff77905403c4d74
Content-Type: text/plain; charset=UTF-8

hi Randy,

Frankly I don't have answer to your questions, but I did reproduced
the issues you described.

And found that:

* `Show Debug Info` menu item was(created, but) not added to the menu.
* if the `showDebug` setting was set to true, the the initial widgets
state will not be set correctly.

I did a patch of those issues fixed.

If you choose to keep the `showDebug` stuff in, you can checkout/test the patch.

On Tue, Nov 1, 2016 at 3:47 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 10/17/16 10:28, Randy Dunlap wrote:
>> Boris or Thiago,
>>
>> Any comments, suggestions, or patches about this?
>>
>> thanks.
>
> Hi Boris and Thiago,
>
> Other than you patch of Oct. 17 (which needs to be added to linux-kconfig for
> linux-next testing), the OP (Jason) mentioned that the xconfig "Help, Introduction"
> mentions a toggle called "Show Debug Info" but there is no such option under
> the Option menu.
>
> The qconf.cc source file does contain a boolean called _showDebug. How is it
> used?  It appears to only be settable by editing the .config/kernel.org/qconf.conf
> file:
> qconf\help\showDebug=false
> and changing that 'false' to 'true'. Doing that still does not show any debug options
> in the xconfig windows. What it appears to do is to highlight (via html) the kconfig
> keywords so that the user can click on them, but when I do that, nothing useful
> happens (they just disappear!).
>
> So the questions are basically:
>
> 1. should be Help/Introduction text be cleaned up so that it does not refer to
> Show Debug Options? or should that toggle be reinstated?
>
> 2. how is /showDebug used? should it be documented? should it be fixed?
> should it be deleted?
>
> Thanks.
>
>> On 10/15/16 04:09, Jason Vas Dias wrote:
>>>  Aha, thanks! I never would have known this without being told -
>>>  there is no visible indication that the symbol info pane exists
>>>  at all until one tries to drag the lower right corner of the window
>>>  notth-eastwards - is this meant to be somehow an intuitive thing to
>>>  do these days to view more info ?
>>>
>>>  I did manage to view the option documentation with nconfig  /
>>>  using emacs to view the KConf files (preferable).
>>>
>>>  Really, it would be nice if xconfig had some 'View' Menu & one could select
>>>  View -> Option Documentation  or press <F1> over an option to view the
>>>  documentation for it , and if the geometry of the different panes was
>>> correct at
>>>  startup .- the whole Option value pane initially appears on the far right hand
>>>  side, about 10 pixels wide , until resized ; and there really is no sign of the
>>>  documentation pane at all until lower right-hand corner dragged.
>>>
>>>  Also, in the Help -> Introduction panel, it says :
>>>    "Toggling Show Debug Info under the Options menu will show the
>>> dependencies..."
>>>  but there is no "Show Debug Info" option on the Options menu - sounds like
>>>  it might be a useful feature - should I be seeing a "Show Debug Info" option ?
>>>  why don't I see one ?  Maybe the Options menu might be a good place to put
>>>  an "Expand Option Documentation Pane" option ?
>>>
>>> Thanks anyway for the info.
>>>
>>> Regards,
>>> Jason
>>>
>>>
>>>
>>>
>>> On 11/10/2016, Randy Dunlap <rdunlap@infradead.org> wrote:
>>>> [changed linux-config to linux-kbuild list]
>>>>
>>>> On 10/09/16 13:46, Jason Vas Dias wrote:
>>>>> Hi -
>>>>> I've been doing 'make xconfig'  to configure the kernel for many years
>>>>> now, and
>>>>> always there used to be some option documentation pane populated with
>>>>> summary documentation for the specific option selected .
>>>>> But now,  when built for Qt 5.7.0, (also tried Qt 4.8 and GTK) there
>>>>> is no option
>>>>> documentation pane - this is a real pain !  The option documentation also
>>>>> is not displayed with any other gui, eg.  'make menuconfig' / 'make
>>>>> gtkconfig' -
>>>>> I'm sure it used to be . This is a regression IMHO .
>>>>> How can I restore display of documentation for each selected option ?
>>>>> Will older xconfig work for Linux 4.8 ? it appears not ...
>>>>> Thanks in advance for any replies,
>>>>> Jason
>>>>
>>>> That's odd. I see the help info in all of xconfig, gconfig, menuconfig, &
>>>> nconfig.
>>>>
>>>> In xconfig, if the right hand side of the config window only lists some
>>>> kernel config
>>>> options and no symbol help/info, the symbol info portion may be hidden. Try
>>>> pointing
>>>> to the bottom of the right side of the window and hold down the left mouse
>>>> button
>>>> and then drag the mouse pointer upward to open the symbol info pane.
>>>> At least that is what works for me.
>
>
> --
> ~Randy



-- 
Boris Barbulovski
http://mkfusion.bokicsoft.com/

--001a11402ee2bff77905403c4d74
Content-Type: text/x-patch; charset=US-ASCII; 
	name="0001-xconfig-Fix-Show-Debug-functionality.patch"
Content-Disposition: attachment; 
	filename="0001-xconfig-Fix-Show-Debug-functionality.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_iuzgl4780

RnJvbSA1MWExMDFmMjU2MTgzYWVkODQwZTQwYzA5YzRiMzczOWZkODI1NDBhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBCb3JpcyBCYXJidWxvdnNraSA8YmJhcmJ1bG92c2tpQGdtYWls
LmNvbT4KRGF0ZTogVHVlLCAxIE5vdiAyMDE2IDA5OjU0OjE1ICswMTAwClN1YmplY3Q6IFtQQVRD
SCAxLzFdIHhjb25maWcgLSBGaXggYFNob3cgRGVidWdgIGZ1bmN0aW9uYWxpdHkuCgoqIEFkZCBg
U2hvdyBkZWJ1Z2AgbWVudSB0byB0aGUgbWFpbiBtZW51LgoqIFByb3Blcmx5IGxvYWQgc2hvd0Rl
YnVnIHNldHRpbmdzLgoKU2lnbmVkLW9mZi1ieTogQm9yaXMgQmFyYnVsb3Zza2kgPGJiYXJidWxv
dnNraUBnbWFpbC5jb20+Ci0tLQogc2NyaXB0cy9rY29uZmlnL3Fjb25mLmNjIHwgMyArKy0KIDEg
ZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg
YS9zY3JpcHRzL2tjb25maWcvcWNvbmYuY2MgYi9zY3JpcHRzL2tjb25maWcvcWNvbmYuY2MKaW5k
ZXggZmM1NTU1OS4uNDVlMzE2OSAxMDA2NDQKLS0tIGEvc2NyaXB0cy9rY29uZmlnL3Fjb25mLmNj
CisrKyBiL3NjcmlwdHMva2NvbmZpZy9xY29uZi5jYwpAQCAtMTAxNCw3ICsxMDE0LDcgQEAgQ29u
ZmlnSW5mb1ZpZXc6OkNvbmZpZ0luZm9WaWV3KFFXaWRnZXQqIHBhcmVudCwgY29uc3QgY2hhciAq
bmFtZSkKIAogCWlmICghb2JqZWN0TmFtZSgpLmlzRW1wdHkoKSkgewogCQljb25maWdTZXR0aW5n
cy0+YmVnaW5Hcm91cChvYmplY3ROYW1lKCkpOwotCQlfc2hvd0RlYnVnID0gY29uZmlnU2V0dGlu
Z3MtPnZhbHVlKCIvc2hvd0RlYnVnIiwgZmFsc2UpLnRvQm9vbCgpOworCQlzZXRTaG93RGVidWco
Y29uZmlnU2V0dGluZ3MtPnZhbHVlKCIvc2hvd0RlYnVnIiwgZmFsc2UpLnRvQm9vbCgpKTsKIAkJ
Y29uZmlnU2V0dGluZ3MtPmVuZEdyb3VwKCk7CiAJCWNvbm5lY3QoY29uZmlnQXBwLCBTSUdOQUwo
YWJvdXRUb1F1aXQoKSksIFNMT1Qoc2F2ZVNldHRpbmdzKCkpKTsKIAl9CkBAIC0xNDc0LDYgKzE0
NzQsNyBAQCBDb25maWdNYWluV2luZG93OjpDb25maWdNYWluV2luZG93KHZvaWQpCiAJb3B0aW9u
TWVudS0+YWRkU2VwYXJhdG9yKCk7CiAJb3B0aW9uTWVudS0+YWRkQWN0aW9ucyhvcHRHcm91cC0+
YWN0aW9ucygpKTsKIAlvcHRpb25NZW51LT5hZGRTZXBhcmF0b3IoKTsKKwlvcHRpb25NZW51LT5h
ZGRBY3Rpb24oc2hvd0RlYnVnQWN0aW9uKTsKIAogCS8vIGNyZWF0ZSBoZWxwIG1lbnUKIAltZW51
LT5hZGRTZXBhcmF0b3IoKTsKLS0gCjIuMTAuMgoK
--001a11402ee2bff77905403c4d74--